I have the option of trading a Polytech M1a with nikon 3x-9x for a nice condition Kimber Warrior. First off, would you recommend the Warrior? I've heard mixed things about Kimber, but it is a beautiful gun if I may say so. Good trade? Bad Trade?

I would, I own two. Bought my first one a Dersert Warrior in 2012, got around 2000 rounds fired and it's been great, the finish is also holding up very nicely.
I just bought a Warrior SOC, only a couple hundred rounds fired, but so far good to go, I like the fact the Warrior series has just what you need and nothing else, also like the choice of different colored finish, black/tan/green & tan. It is also a series 70 gun, no firing pin safety. I am not just a Kimber fanboy, I own several other 1911s, Ed Brown SF and TRP to name two. Kimber gets a bad rap on the Internet, I believe they are just as good and better in someways as others in their price range.
As far as the trade, I'd probably keep the M1A. But do you want a railed 1911 or a AR15?

Kimber Warrior for an M1a sounds like you are getting the shaft...... Maybe it the pistol pot was sweetened a little bit.  I was able to pick up a Kimber Grand Raptor for $900 used new Warrior would run you 1000 a used anywhere from 750-900.  Polytech M1a around $1000-1200 maybe more depending on the scope mount.

It all depends on how bad you want it.  That's the standard

I use a Warrior for EDC.  It is a tack driver and is far better than I can shoot.

I know its a driver because I have had a few good shooters a lot younger than myself shoot it when I first bought it and were quite impressed.