I'll give you my thoughts, worth what I'm chargin' ya...
I've been a paying member of two 'semi-private' clubs.
The first was in Pinellas County, FL (the Wyoming Antelope Club).
This range is a covered, outdoor range smack in the middle of the most populated county in Florida. The greater Tampa area population is probably 3+ million people.
It had everything you mentioned except sporting clays and rifle ranges over 100 yds (I think they've put in a 200 yd line since I left). It has a clubhouse, serves beer when shooting is done, hosts major IDPA events, training, yadda yadda yadda.
Membership was ~$240/yr and your daily rate went down to $5/day as a member.
The general public could shoot (at the public line only - ie, benched longarms, no rapid fire, pistol under control, paper bullseye targets only) for $15/day.
Easy access and the public line helped in my view and there were multiple volunteers (shoot for free, shoot after line closed) who generally kept a tight ship. One or two were simply assholes, but most were just fellow shooters hanging out for the day or retired folk (it is FL).
You can lookup youtube videos of the range but it made enough money to install 4-5 levels of ~ 20ftx8ft pre-stressed concrete baffles across approximately 60 shooting positions along with massive earth and timberworks.
All this to reduce liability so the range could stay open and serve the 1000+ member along with the general public.
There was a second major range about 1 hr north of Tampa (Hernando Sportsmans Club) where they host 2-3 major machinegun shoots each year, 200 yd covered line, 100 yd covered public line, multiple bays, sporting clays, cowboy action, yadda yadda yadda.
So this range was a little bit of a drive but the annual dues were ~$125/yr and about $10 to shoot all day. Much more flexible (could shoot machinegun, whatever but don't act like a dumbass).
Even though it was a lot cheaper and more flexible (I also shot practical rifle matches there) I didn't join because it was really a hike and I went there once a month anyway to shoot a match for $10.
The second range I joined was here in Memphis (MSSA). All the stuff you mentioned except the longest line is 600 yds.
It's $600 for the first year and then about $200/yr from that point forward.
After my earlier experiences in Florida I was shocked at the price but I paid it because this is really the only game in town unless you want to shoot indoors and that's not only a hassle (to me) it also gets expensive very quickly.
This range is what I'd call semi-private, members can bring guests up to 3x but the general public is excluded.
Lots of flexibility once you get checked out (setup steel, setup practical stages and plink, etc etc)
I like it a LOT.
From what I see MSSA do pretty well but even with the yearly fee, money seems a little tighter than it was at either of the other two clubs I knew in FL.
My takeaway?
You really need money from the general public to make it very profitable. But you'll also have to deal with the general public and people acting like fucktards or nincompoops so be prepared to kick folks out or have eagle-eyed RSO's.
The clays stuff is a moneymaker, the basic lines (pistol and rifle) are de rigeur. The other stuff is nice but is a loss leader.
I hardly EVER see people on the long distance ranges. That's going to be like 2% of your visitors.
I don't know his market but I think he's pricing himself too high and the 'perks' probably aren't going to attract a lot of shooters at first.
Good luck with it.