I went to Walmart and they had some Remington Gun socks that I had read about people here using so I bought a bunch. I figure that it will be good to put the socks on the guns in the safe to prevent scratches.

I also have a gun that I store in a soft case in my closet. Is it overkill for me to put the gun in the sock and then in the soft case? Any potential problems if I leave the socks on long term (years) in the safe?

I think the Sock is also silicon treated, right?  This should help guard against corrosion, especially if you don't keep your gun in a safe with a dehumidifier.

Yes, they are silicone treated.

When storing guns in cases, ventilation is key to preventing corrosion.  The gun socks are fine for protecting guns from dust, scratches, and hand oils.  They are treated to resist rust and they will allow decent airflow.  I don't think you should put one inside a sock inside a soft case though.  Use one or the other.