Quoted:
Question #1 - What batteries do you use for your optics?
Question #2 - Good to remove them from infrequently used electronic devices?
Answer # 1: I use Duracell 1/3N on my Aimpoint and N type on my EOTech.
Answer # 2: Yes, it's a good idea to remove batteries from any devices when not in use for long periods of time.
I use my optics and lights all the time so they're always loaded with fresh batteries, also I always replace them before they're worn out, plus I always carry spares on my AR either in the battery compartment on my optic mount or my MIAD grip.
I'm a long time Aimpoint owner for 21 years and I never had a battery leak with my old Aimpoint 2000 which I use all the time, same with my current Aimpoint and EOTech, I would expect leaks to happen but it would be a rare possibility so I don't worry too much about it.